commit 7bda8342e49a07762cf8dae5cddc067409935b4f parent 7194a0cfe67aa64725c52b95749120a1e6775c0f Author: Sergej Orlov <wladimirych@gmail.com> Date: Sat, 11 Apr 2026 10:51:59 +0200 tracks[strava]: Update error messages according to changes at Strava Now private tracks are reported as not existing Diffstat:
6 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/src/lib/leaflet.control.track-list/lib/services/strava.js b/src/lib/leaflet.control.track-list/lib/services/strava.js @@ -40,14 +40,14 @@ class Strava extends BaseService { } parseResponse(responses) { - const statusMessages = { - 401: 'Requested Strava activity marked as private', - 404: 'Requested Strava activity could not be found' - }; const [pageResponse, trackResponse] = responses; + if (trackResponse.status === 404) { + return [{error: 'Strava activity is deleted or marked as private'}]; + } if (trackResponse.status !== 200) { - return [{error: statusMessages[trackResponse.status]}]; + return [{error: 'NETWORK', name: this.origUrl}]; } + let name = `Strava ${this.trackId}`; const latlngs = trackResponse.responseJSON?.latlng; if (!latlngs || !Array.isArray(latlngs)) { @@ -94,13 +94,13 @@ class StravaShortUrl extends BaseService { parseResponse(responses) { const response = responses[0]; - const url = corsProxyOriginalUrl(response.responseURL); if (response.status === 404) { - return [{error: 'Requested Strava activity was deleted'}]; + return [{error: 'Strava activity is deleted or marked as private'}]; } + const url = corsProxyOriginalUrl(response.responseURL); const strava = new Strava(url); if (!strava.isOurUrl()) { - return [{error: 'Bad short link for Strava activity or activity is marked as private'}]; + return [{error: 'Bad short link for Strava activity'}]; } return strava.geoData(); } diff --git a/test/track_load_data/testcases/strava_not_exists.json b/test/track_load_data/testcases/strava_not_exists.json @@ -1,4 +1,4 @@ { "query": ["https://www.strava.com/activities/3873704997123"], - "geodata": [{"error": "Requested Strava activity could not be found"}] + "geodata": [{"error": "Strava activity is deleted or marked as private"}] } diff --git a/test/track_load_data/testcases/strava_private.json b/test/track_load_data/testcases/strava_private.json @@ -1,4 +1,4 @@ { "query": ["https://www.strava.com/activities/3875236492", "https://www.strava.com/activities/3875227310"], - "geodata": [{"error": "Requested Strava activity marked as private"}] + "geodata": [{"error": "Strava activity is deleted or marked as private"}] } diff --git a/test/track_load_data/testcases/strava_short_url_deleted.json b/test/track_load_data/testcases/strava_short_url_deleted.json @@ -1,4 +1,4 @@ { "query": ["https://strava.app.link/Sq2CMRdTUPb"], - "geodata": [{"error": "Requested Strava activity was deleted"}] + "geodata": [{"error": "Strava activity is deleted or marked as private"}] } diff --git a/test/track_load_data/testcases/strava_short_url_not_exists.json b/test/track_load_data/testcases/strava_short_url_not_exists.json @@ -1,4 +1,4 @@ { "query": ["https://strava.app.link/Sq2CMRdTU"], - "geodata": [{"error": "Bad short link for Strava activity or activity is marked as private"}] + "geodata": [{"error": "Bad short link for Strava activity"}] } diff --git a/test/track_load_data/testcases/strava_short_url_private.json b/test/track_load_data/testcases/strava_short_url_private.json @@ -1,4 +1,4 @@ { "query": ["https://strava.app.link/hRestZOPUPb"], - "geodata": [{"error": "Bad short link for Strava activity or activity is marked as private"}] + "geodata": [{"error": "Strava activity is deleted or marked as private"}] }