commit a7fc2d2babf4745dbda5ff2bfe5ecee31f126652
parent b7a4cd586cde083456ee95fd3e6f29a27a1c55b7
Author: Sergey Orlov <wladimirych@gmail.com>
Date: Thu, 17 Sep 2020 10:37:16 +0200
eslint: refactor - move rules to separate files, use list of legacy files
Diffstat:
11 files changed, 629 insertions(+), 439 deletions(-)
diff --git a/.eslintrc b/.eslintrc
@@ -1,155 +0,0 @@
-{
- "root": true,
- "ignorePatterns": [
- "node_modules",
- "build",
- "deploy"
- ],
- "extends": ["./myEslintRules.js", "prettier" ],
- "plugins": [
- "prettier"
- ],
- "rules": {
- "prettier/prettier": "error",
- /* rules softly disabled by prettier */
- "max-len": ["error", {"code": 120}],
- "arrow-body-style": ["error", "as-needed"],
- "curly": "error",
- "no-confusing-arrow": "error",
- "no-tabs": "error",
- "no-unexpected-multiline": "error",
- "quotes": ["error", "single", {"allowTemplateLiterals": false}],
- },
- "overrides": [
- {
- "files": "src/**/*.js", // for legacy code
- "env": {
- "browser": true,
- "es2020": true,
- "commonjs": true
- },
- "parser": "babel-eslint",
- "parserOptions": {
- "sourceType": "module"
- },
- "extends": ["./myEslintBrowserRules.js"], // do not disable rules conflicting with prettier
- "rules": {
- "no-constant-condition": ["error", {"checkLoops": false}], // allow `while (true)`
- "no-prototype-builtins": "off",
- "no-invalid-this": "off", // 44 occurencies in old code
- "no-magic-numbers": "off", // 1188 occurencies in old code
- "no-param-reassign": "off", // 91 occurencies in old code
- "no-warning-comments": "off", // 15 occurencies in old code
- "no-shadow": "off", // 83 occurencies in old code
- "camelcase": "off", // 203 occurencies in old code
- "comma-dangle": ["error", "only-multiline"], // 697 issues with always-multiline
- "quotes": "off", // 73 occurencies in old code
- "function-paren-newline": "off", // > 200 occurencies in old code
- "indent": "off", // > 7000 occurencies in old code
- "no-multi-assign": "off", // 31 occurencies in old code
- "no-var": "off", // 330 occurencies in old code
- "one-var": "off", // 122 occurencies in old code
- "prefer-const": "off", // 375 occurencies in old code
- "prefer-template": "off", // 70 occurencies in old code,
- "prettier/prettier": "off",
- },
- "globals": {
- "NODE_ENV": true,
- "RELEASE_VER": true
- }
- },
- {
- "files": "src/vendored/**/*.js",
- "rules": {
- "semi": "off",
- "no-console": "off",
- "block-scoped-var": "off",
- "consistent-return": "off",
- "curly": "off",
- "no-empty-function": "off",
- "no-implicit-coercion": "off",
- "no-magic-numbers": "off",
- "no-multi-spaces": "off",
- "no-param-reassign": "off",
- "no-throw-literal": "off",
- "no-warning-comments": "off",
- "require-unicode-regexp": "off",
- "strict": "off",
- "no-shadow": "off",
- "no-use-before-define": "off",
- "camelcase": "off",
- "comma-dangle": "off",
- "comma-style": "off",
- "consistent-this": "off",
- "func-style": "off",
- "max-len": "off",
- "no-tabs": "off",
- "quotes": "off",
- "indent": "off",
- "keyword-spacing": "off",
- "linebreak-style": "off",
- "no-multi-assign": "off",
- "no-multiple-empty-lines": "off",
- "no-plusplus": "off",
- "no-var": "off",
- "object-curly-spacing": "off",
- "one-var": "off",
- "operator-linebreak": "off",
- "padded-blocks": "off",
- "semi-spacing": "off",
- "semi-style": "off",
- "space-before-blocks": "off",
- "space-before-function-paren": "off",
- "space-in-parens": "off",
- "space-infix-ops":"off",
- "space-unary-ops": "off",
- "spaced-comment": "off"
- }
- },
- {
- "files": "src/**/*_pb.js", // auto-generated files
- "rules": {
- "curly": "off",
- "strict": "off",
- "max-len": "off",
- "no-multiple-empty-lines": "off",
- "space-before-function-paren": "off",
- "quote-props": "off"
- }
- },
- {
- "files": "test/**/*.js",
- "excludedFiles": "test/karma.conf.js",
- "parser": "babel-eslint",
- "env": {
- "browser": true,
- "mocha": true,
- "es2020": true
- },
- "parserOptions": {
- "sourceType": "module"
- },
- "globals": {
- "require": true,
- "assert": true
- },
- "rules": {
- "max-nested-callbacks": ["error", 5],
- "no-invalid-this": "off"
- }
- },
- {
- "files": [
- "webpack/**/*.js",
- "test/karma.conf.js",
- "scripts/**/*.js",
- "./myEslintRules.js",
- "./myEslintBrowserRules.js"
- ],
- "env": {
- "node": true,
- "es2017": true
- }
- }
- ]
-}
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -0,0 +1,83 @@
+'use strict';
+
+const legacyFiles = require('./eslint_rules/legacy_files_list');
+const vendoredFiles = './src/vendored/**/*.js';
+const protobufFiles = './src/**/*_pb.js';
+
+module.exports = {
+ root: true,
+ ignorePatterns: ['node_modules', 'build', 'deploy'],
+ extends: ['./eslint_rules/base.js'],
+ overrides: [
+ {
+ files: './**/*.js',
+ excludedFiles: [...legacyFiles, vendoredFiles, protobufFiles],
+ extends: ['./eslint_rules/prettier.js'],
+ },
+ {
+ files: './src/**/*.js', // web application
+ env: {
+ browser: true,
+ es2020: true,
+ commonjs: true,
+ },
+ parser: 'babel-eslint',
+ parserOptions: {
+ sourceType: 'module',
+ },
+ globals: {
+ NODE_ENV: true,
+ RELEASE_VER: true,
+ },
+ },
+ {
+ files: legacyFiles, // for legacy code
+ extends: ['./eslint_rules/relax_legacy.js'],
+ },
+ {
+ files: vendoredFiles,
+ extends: ['./eslint_rules/relax_vendored.js'],
+ },
+ {
+ files: protobufFiles, // auto-generated files
+ extends: ['./eslint_rules/relax_protobuf.js'],
+ },
+ {
+ files: './test/**/*.js',
+ excludedFiles: './test/karma.conf.js',
+ parser: 'babel-eslint',
+ extends: ['./eslint_rules/relax_tests.js'],
+ env: {
+ browser: true,
+ mocha: true,
+ es2020: true,
+ },
+ parserOptions: {
+ sourceType: 'module',
+ },
+ globals: {
+ require: true,
+ assert: true,
+ },
+ },
+ {
+ files: [
+ './webpack/**/*.js',
+ './test/karma.conf.js',
+ './scripts/**/*.js',
+ './eslint_rules/*.js',
+ './.eslintrc.js',
+ ],
+ env: {
+ node: true,
+ es2017: true,
+ },
+ },
+ {
+ files: ['./scripts/build.js', './webpack/webpack.config.js'],
+ rules: {
+ 'no-console': 'off',
+ },
+ },
+ ],
+};
diff --git a/eslint_rules/base.js b/eslint_rules/base.js
@@ -0,0 +1,277 @@
+'use strict';
+
+module.exports = {
+ extends: ['eslint:recommended'],
+ rules: {
+ 'accessor-pairs': 'error',
+ 'array-bracket-newline': ['error', 'consistent'],
+ 'array-bracket-spacing': 'error',
+ 'array-callback-return': 'error',
+ 'array-element-newline': ['error', 'consistent'],
+ 'arrow-body-style': ['error', 'as-needed'], // disabled by prettier-config
+ 'arrow-parens': 'error',
+ 'arrow-spacing': 'error',
+ 'block-scoped-var': 'error',
+ // 'block-spacing': 'error', // for single line blocks, not needed
+ 'brace-style': 'error',
+ // 'callback-return': 'error', // specific to nodejs, skip
+ 'camelcase': ['error', {allow: ['_unused_[^_]+']}],
+ // 'capitalized-comments': 'error', // checked, declined
+ // 'class-methods-use-this': 'error', // checked, declined
+ 'comma-dangle': ['error', 'always-multiline'],
+ 'comma-spacing': 'error',
+ 'comma-style': 'error',
+ 'complexity': 'error',
+ 'computed-property-spacing': 'error',
+ 'consistent-return': 'error',
+ 'consistent-this': 'error',
+ // 'constructor-super': 'error', // in eslint-recommended
+ 'curly': 'error', // disabled by prettier-config
+ 'default-case': 'error',
+ 'default-param-last': 'error',
+ 'dot-location': ['error', 'property'],
+ // 'dot-notation': 'error', // checked, declined
+ 'eol-last': 'error',
+ 'eqeqeq': 'error',
+ // 'for-direction': 'error', // in eslint-recommended
+ 'func-call-spacing': 'error',
+ // 'func-name-matching': 'error', // checked, declined
+ // 'func-names': 'error', // checked, declined
+ 'func-style': ['error', 'declaration'],
+ // 'function-call-argument-newline': 'error', // checked, declined
+ 'function-paren-newline': 'error',
+ 'generator-star-spacing': ['error', {named: 'after', anonymous: 'neither', method: 'before'}],
+ // 'getter-return': 'error', // in eslint-recommended
+ // 'global-require': 'error', // specific to nodejs, skip
+ 'grouped-accessor-pairs': 'error',
+ 'guard-for-in': 'error',
+ // 'handle-callback-err': 'error', // specific to nodejs, skip
+ // 'id-blacklist': 'error', // checked, declined
+ // 'id-length': 'error', // checked, declined
+ // 'id-match': 'error', // checked, declined
+ // 'implicit-arrow-linebreak': 'error', // checked, declined
+ 'indent': 'error',
+ // 'init-declarations': 'error', // checked, declined
+ // 'jsx-quotes': 'error', // jsx not used
+ 'key-spacing': 'error',
+ 'keyword-spacing': 'error',
+ // 'line-comment-position': 'error', //checked, declined
+ 'linebreak-style': 'error',
+ // 'lines-around-comment': 'error', // checked, declined
+ 'lines-between-class-members': ['error', 'always', {exceptAfterSingleLine: true}],
+ // 'max-classes-per-file': 'error', // checked, declined
+ 'max-depth': 'error',
+ 'max-len': ['error', {code: 120}],
+ // 'max-lines': 'error', // checked, declined
+ // 'max-lines-per-function': 'error', // checked, declined
+ 'max-nested-callbacks': ['error', 2],
+ // 'max-params': 'error', // checked, declined
+ // 'max-statements': 'error', // checked, declined
+ 'max-statements-per-line': 'error',
+ // 'multiline-comment-style': 'error', // checked, declined
+ // 'multiline-ternary': 'error', // checked, declined
+ 'new-cap': 'error',
+ 'new-parens': 'error',
+ // 'newline-per-chained-call': 'error', // checked, declined
+ // 'no-alert': 'error', // checked, declined
+ 'no-array-constructor': 'error',
+ // 'no-async-promise-executor': 'error', // in eslint-recommended
+ // 'no-await-in-loop': 'error', // checked, declined
+ // 'no-bitwise': 'error', // checked, declined
+ // 'no-buffer-constructor': 'error', // specific to nodejs, skip
+ 'no-caller': 'error',
+ // 'no-case-declarations': 'error', // in eslint-recommended
+ // 'no-class-assign': 'error', // in eslint-recommended
+ // 'no-compare-neg-zero': 'error', // in eslint-recommended
+ // 'no-cond-assign': 'error', // in eslint-recommended
+ 'no-confusing-arrow': 'error',
+ 'no-console': 'error',
+ // 'no-const-assign': 'error', // in eslint-recommended
+ // 'no-constant-condition': 'error', // in eslint-recommended
+ 'no-constructor-return': 'error',
+ // 'no-continue': 'error', // checked, declined
+ // 'no-control-regex': 'error', // in eslint-recommended
+ // 'no-debugger': 'error', // in eslint-recommended
+ // 'no-delete-var': 'error', // in eslint-recommended
+ // 'no-div-regex': 'error', // checked, declined
+ // 'no-dupe-args': 'error', // in eslint-recommended
+ // 'no-dupe-class-members': 'error', // in eslint-recommended
+ 'no-dupe-else-if': 'error',
+ // 'no-dupe-keys': 'error', // in eslint-recommended
+ // 'no-duplicate-case': 'error', // in eslint-recommended
+ 'no-duplicate-imports': 'error',
+ 'no-else-return': 'error',
+ // 'no-empty': 'error', // in eslint-recommended
+ // 'no-empty-character-class': 'error', // in eslint-recommended
+ 'no-empty-function': 'error',
+ // 'no-empty-pattern': 'error', // in eslint-recommended
+ 'no-eq-null': 'error',
+ 'no-eval': 'error',
+ // 'no-ex-assign': 'error', // in eslint-recommended
+ 'no-extend-native': 'error',
+ 'no-extra-bind': 'error',
+ // 'no-extra-boolean-cast': 'error', // in eslint-recommended
+ 'no-extra-label': 'error',
+ // 'no-extra-parens': 'error', // checked, declined
+ // 'no-extra-semi': 'error', // in eslint-recommended
+ // 'no-fallthrough': 'error', // in eslint-recommended
+ 'no-floating-decimal': 'error',
+ // 'no-func-assign': 'error', // in eslint-recommended
+ // 'no-global-assign': 'error', // in eslint-recommended
+ 'no-implicit-coercion': 'error',
+ 'no-implicit-globals': 'error',
+ 'no-implied-eval': 'error',
+ 'no-import-assign': 'error',
+ // 'no-inline-comments': 'error', // checked, declined
+ // 'no-inner-declarations': 'error', // in eslint-recommended
+ // 'no-invalid-regexp': 'error', // in eslint-recommended
+ 'no-invalid-this': 'error',
+ // 'no-irregular-whitespace': 'error', // in eslint-recommended
+ 'no-iterator': 'error',
+ 'no-label-var': 'error',
+ 'no-labels': 'error', // not quire sure if this should be enabled
+ 'no-lone-blocks': 'error',
+ // 'no-lonely-if': 'error', // checked, declined
+ 'no-loop-func': 'error',
+ // 'no-magic-numbers': 'error', // checked, declined
+ // 'no-misleading-character-class': 'error', // in eslint-recommended
+ // 'no-mixed-operators': 'error', // checked, declined
+ 'no-mixed-requires': 'error',
+ // 'no-mixed-spaces-and-tabs': 'error', // in eslint-recommended
+ 'no-multi-assign': 'error',
+ 'no-multi-spaces': [
+ 'error',
+ {
+ ignoreEOLComments: true,
+ exceptions: {Property: false},
+ },
+ ],
+ 'no-multi-str': 'error',
+ 'no-multiple-empty-lines': ['error', {max: 1}],
+ 'no-negated-condition': 'error',
+ 'no-nested-ternary': 'error',
+ 'no-new': 'error',
+ 'no-new-func': 'error',
+ 'no-new-object': 'error',
+ 'no-new-require': 'error',
+ // 'no-new-symbol': 'error', // in eslint-recommended
+ 'no-new-wrappers': 'error',
+ // 'no-obj-calls': 'error', // in eslint-recommended
+ // 'no-octal': 'error', // in eslint-recommended
+ 'no-octal-escape': 'error',
+ 'no-param-reassign': 'error',
+ 'no-path-concat': 'error',
+ 'no-plusplus': ['error', {allowForLoopAfterthoughts: true}],
+ // 'no-process-env': 'error', // checked, declined
+ // 'no-process-exit': 'error', // checked, declined
+ 'no-proto': 'error',
+ // 'no-prototype-builtins': 'error', // in eslint-recommended
+ // 'no-redeclare': 'error', // in eslint-recommended
+ // 'no-regex-spaces': 'error', // in eslint-recommended
+ // 'no-restricted-globals': 'error', // no forbidden globals defined so far
+ // 'no-restricted-imports': 'error', // checked, declined
+ // 'no-restricted-modules': 'error', // checked, declined
+ // 'no-restricted-properties': 'error', // no forbidden properties defined so far
+ 'no-restricted-syntax': ['error', 'SequenceExpression'],
+ 'no-return-assign': 'error',
+ 'no-return-await': 'error',
+ 'no-script-url': 'error',
+ // 'no-self-assign': 'error', // in eslint-recommended
+ 'no-self-compare': 'error',
+ 'no-sequences': 'error',
+ 'no-setter-return': 'error',
+ 'no-shadow': ['error', {builtinGlobals: true}],
+ // 'no-shadow-restricted-names': 'error', // in eslint-recommended
+ // 'no-sparse-arrays': 'error', // in eslint-recommended
+ // 'no-sync': 'error', // checked, declined
+ 'no-tabs': 'error',
+ 'no-template-curly-in-string': 'error',
+ // 'no-ternary': 'error', // checked, declined
+ // 'no-this-before-super': 'error', // in eslint-recommended
+ 'no-throw-literal': 'error',
+ 'no-trailing-spaces': 'error',
+ // 'no-undef': 'error', // in eslint-recommended
+ 'no-undef-init': 'error',
+ // 'no-undefined': 'error', // not needed since no-global-assign and no-shadow-restricted-names are enabled
+ // 'no-underscore-dangle': 'error', // checked, declined
+ // 'no-unexpected-multiline': 'error', // in eslint-recommended
+ 'no-unmodified-loop-condition': 'error',
+ 'no-unneeded-ternary': 'error',
+ // 'no-unreachable': 'error', // in eslint-recommended
+ // 'no-unsafe-finally': 'error', // in eslint-recommended
+ // 'no-unsafe-negation': 'error', // in eslint-recommended
+ 'no-unused-expressions': 'error',
+ // 'no-unused-labels': 'error', // in eslint-recommended
+ 'no-unused-vars': ['error', {argsIgnorePattern: '_unused(_.+)?'}], // redefine eslint-recommended
+ 'no-use-before-define': 'error',
+ 'no-useless-call': 'error',
+ // 'no-useless-catch': 'error', // in eslint-recommended
+ 'no-useless-computed-key': ['error', {enforceForClassMembers: true}],
+ 'no-useless-concat': 'error',
+ 'no-useless-constructor': 'error',
+ // 'no-useless-escape': 'error', // in eslint-recommended
+ 'no-useless-rename': 'error',
+ 'no-useless-return': 'error',
+ 'no-var': 'error',
+ 'no-void': 'error',
+ 'no-warning-comments': 'error',
+ 'no-whitespace-before-property': 'error',
+ // 'no-with': 'error', // in eslint-recommended
+ // 'nonblock-statement-body-position': 'error', // not needed since if-s without block are not allowed
+ 'object-curly-newline': 'error',
+ 'object-curly-spacing': 'error',
+ 'object-property-newline': ['error', {allowAllPropertiesOnSameLine: true}],
+ // 'object-shorthand': 'error', // checked, declined
+ 'one-var': ['error', 'never'],
+ 'one-var-declaration-per-line': 'error',
+ 'operator-assignment': 'error',
+ 'operator-linebreak': 'error',
+ 'padded-blocks': ['error', 'never'],
+ // 'padding-line-between-statements': 'error', // checked, declined
+ // 'prefer-arrow-callback': 'error', // checked, declined
+ 'prefer-const': 'error',
+ // 'prefer-destructuring': 'error', // checked, declined
+ 'prefer-exponentiation-operator': 'error',
+ // 'prefer-named-capture-group': 'error', // checked, declined
+ 'prefer-numeric-literals': 'error',
+ 'prefer-object-spread': 'error',
+ 'prefer-promise-reject-errors': 'error',
+ 'prefer-regex-literals': 'error',
+ 'prefer-rest-params': 'error',
+ 'prefer-spread': 'error',
+ // 'prefer-template': 'error', // checked, declined
+ 'quote-props': ['error', 'consistent-as-needed'],
+ 'quotes': ['error', 'single', {allowTemplateLiterals: false}],
+ 'radix': 'error',
+ 'require-atomic-updates': 'error',
+ // 'require-await': 'error', // checked, declined
+ 'require-unicode-regexp': 'error',
+ // 'require-yield': 'error', // in eslint-recommended
+ 'rest-spread-spacing': 'error',
+ 'semi': 'error',
+ 'semi-spacing': 'error',
+ 'semi-style': 'error',
+ // 'sort-imports': 'error', // checked, declined
+ // 'sort-keys': 'error', // checked, declined
+ // 'sort-vars': 'error', // checked, declined
+ 'space-before-blocks': 'error',
+ 'space-before-function-paren': ['error', 'never'],
+ 'space-in-parens': 'error',
+ 'space-infix-ops': 'error',
+ 'space-unary-ops': 'error',
+ 'spaced-comment': 'error',
+ 'strict': ['error', 'global'],
+ 'switch-colon-spacing': 'error',
+ 'symbol-description': 'error',
+ 'template-curly-spacing': 'error',
+ 'template-tag-spacing': 'error',
+ // 'unicode-bom': 'error', // checked, declined
+ // 'use-isnan': 'error', // in eslint-recommended
+ // 'valid-typeof': 'error', // in eslint-recommended
+ // 'vars-on-top': 'error', // vars should be forbidden
+ // 'wrap-iife': 'error', // checked, declined
+ // 'wrap-regex': 'error', // checked, declined
+ 'yield-star-spacing': 'error',
+ 'yoda': 'error',
+ },
+};
diff --git a/eslint_rules/legacy_files_list.js b/eslint_rules/legacy_files_list.js
@@ -0,0 +1,153 @@
+'use strict';
+
+module.exports = [
+ 'src/lib/leaflet.control.panoramas/lib/mapillary/mvt.js',
+ 'src/lib/leaflet.control.panoramas/lib/mapillary/mapillary-coverage-layer.js',
+ 'src/lib/leaflet.control.panoramas/lib/mapillary/index.js',
+ // 'src/lib/leaflet.control.panoramas/lib/mapillary/vector_tile_pb.js',
+ 'src/lib/leaflet.control.panoramas/lib/mapillary/mapillary-loader.js',
+ 'src/lib/leaflet.control.panoramas/lib/mapycz/apiLoader.js',
+ 'src/lib/leaflet.control.panoramas/lib/mapycz/index.js',
+ 'src/lib/leaflet.control.panoramas/lib/google/index.js',
+ 'src/lib/leaflet.control.panoramas/lib/wikimedia/index.js',
+ 'src/lib/leaflet.control.panoramas/lib/wikimedia/coverage-layer.js',
+ 'src/lib/leaflet.control.panoramas/lib/common/index.js',
+ 'src/lib/leaflet.control.panoramas/index.js',
+ 'src/lib/leaflet.polyline-edit/index.js',
+ 'src/lib/leaflet.control.layers.adaptive-height/index.js',
+ // 'src/lib/leaflet.control.external-maps/index.js',
+ 'src/lib/leaflet.placemark/index.js',
+ 'src/lib/leaflet.layer.geojson-ajax/index.js',
+ 'src/lib/leaflet.layer.geocaching-su/index.js',
+ 'src/lib/file-read/index.js',
+ 'src/lib/CORSProxy/index.js',
+ 'src/lib/leaflet.polyline-measure/index.js',
+ 'src/lib/leaflet.control.coordinates/index.js',
+ 'src/lib/leaflet.control.coordinates/formats.js',
+ 'src/lib/tiled-data-loader/index.js',
+ // 'src/lib/anyElementResizeEvent/index.js',
+ 'src/lib/leaflet.layer.google/index.js',
+ 'src/lib/leaflet.control.jnx/jnx-maker.js',
+ 'src/lib/leaflet.control.jnx/jnx-encoder.js',
+ 'src/lib/leaflet.control.jnx/binary-stream.js',
+ 'src/lib/leaflet.control.jnx/selector.js',
+ 'src/lib/leaflet.control.jnx/index.js',
+ 'src/lib/leaflet.control.jnx/hash-state.js',
+ 'src/lib/leaflet.control.layers.hotkeys/index.js',
+ 'src/lib/leaflet.layer.yandex/index.js',
+ 'src/lib/leaflet.control.commons/index.js',
+ 'src/lib/leaflet.lineutil.simplifyLatLngs/index.js',
+ 'src/lib/cache/index.js',
+ 'src/lib/xhr-promise/index.js',
+ 'src/lib/leaflet.fixes/fixWorldCopyJump.js',
+ 'src/lib/leaflet.fixes/index.js',
+ 'src/lib/leaflet.control.printPages/control.js',
+ 'src/lib/leaflet.control.printPages/decorations.js',
+ 'src/lib/leaflet.control.printPages/pdf.js',
+ 'src/lib/leaflet.control.printPages/decoration.grid.js',
+ 'src/lib/leaflet.control.printPages/decoration.scale.js',
+ 'src/lib/leaflet.control.printPages/map-render.js',
+ 'src/lib/leaflet.control.printPages/decoration.magnetic-meridians.js',
+ 'src/lib/leaflet.control.printPages/pageFeature.js',
+ 'src/lib/leaflet.control.layers.top-row/index.js',
+ 'src/lib/clipboardCopy/index.js',
+ 'src/lib/leaflet.hashState/hashState.js',
+ 'src/lib/leaflet.hashState/Leaflet.Control.Layers.js',
+ 'src/lib/leaflet.hashState/Leaflet.Map.js',
+ 'src/lib/leaflet.hashState/leaflet.hashState.js',
+ // 'src/lib/leaflet.map.sidebars/index.js',
+ 'src/lib/leaflet.control.zoom-display/index.js',
+ 'src/lib/knockout.component.progress/progress.js',
+ 'src/lib/contextmenu/index.js',
+ 'src/lib/leaflet.layer.soviet-topomaps-grid/index.js',
+ 'src/lib/leaflet.layer.wikimapia/wm-utils.js',
+ 'src/lib/leaflet.layer.wikimapia/index.js',
+ 'src/lib/leaflet.layer.wikimapia/wikimapia-loader.js',
+ 'src/lib/leaflet.control.track-list/lib/meridian180.js',
+ 'src/lib/leaflet.control.track-list/lib/services/movescount.js',
+ 'src/lib/leaflet.control.track-list/lib/services/simpleService.js',
+ 'src/lib/leaflet.control.track-list/lib/services/sportstracker.js',
+ 'src/lib/leaflet.control.track-list/lib/services/nakarte/index.js',
+ 'src/lib/leaflet.control.track-list/lib/services/nakarte/loadTracksFromJson.js',
+ 'src/lib/leaflet.control.track-list/lib/services/urlEncode.js',
+ 'src/lib/leaflet.control.track-list/lib/services/baseService.js',
+ 'src/lib/leaflet.control.track-list/lib/services/strava.js',
+ 'src/lib/leaflet.control.track-list/lib/services/endomondo.js',
+ 'src/lib/leaflet.control.track-list/lib/services/index.js',
+ 'src/lib/leaflet.control.track-list/lib/services/garmin.js',
+ 'src/lib/leaflet.control.track-list/lib/services/tracedetrail.js',
+ 'src/lib/leaflet.control.track-list/lib/services/gpslib.js',
+ 'src/lib/leaflet.control.track-list/lib/services/openstreetmapRu.js',
+ 'src/lib/leaflet.control.track-list/lib/services/etomesto.js',
+ 'src/lib/leaflet.control.track-list/lib/services/yandex.js',
+ 'src/lib/leaflet.control.track-list/lib/services/osm.js',
+ 'src/lib/leaflet.control.track-list/lib/services/gpsies.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/jsInflate.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/kml.js',
+ // 'src/lib/leaflet.control.track-list/lib/parsers/nktk_pb.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/nktk.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/gpx.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/index.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/ozi.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/zip.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/codePages.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/urlSafeBase64.js',
+ 'src/lib/leaflet.control.track-list/lib/parsers/xmlUtils.js',
+ 'src/lib/leaflet.control.track-list/lib/loadFromUrl.js',
+ 'src/lib/leaflet.control.track-list/lib/parseGeoFile.js',
+ 'src/lib/leaflet.control.track-list/lib/geo_file_exporters.js',
+ 'src/lib/leaflet.control.track-list/track-list.localstorage.js',
+ 'src/lib/leaflet.control.track-list/control-ruler.js',
+ 'src/lib/leaflet.control.track-list/track-list.hash-state.js',
+ 'src/lib/leaflet.control.track-list/track-list.js',
+ // 'src/lib/leaflet.control.search/index.js',
+ // 'src/lib/leaflet.control.search/providers/coordinates.js',
+ // 'src/lib/leaflet.control.search/providers/remoteBase.js',
+ // 'src/lib/leaflet.control.search/providers/index.js',
+ // 'src/lib/leaflet.control.search/providers/mapycz/index.js',
+ // 'src/lib/leaflet.control.search/providers/photon.js',
+ // 'src/lib/leaflet.control.search/providers/links.js',
+ 'src/lib/leaflet.layer.canvasMarkers/index.js',
+ 'src/lib/notifications/index.js',
+ 'src/lib/binary-strings/index.js',
+ 'src/lib/safe-localstorage/index.js',
+ 'src/lib/leaflet.events.drag/index.js',
+ 'src/lib/magnetic-declination/index.js',
+ 'src/lib/leaflet.control.caption/index.js',
+ 'src/lib/leaflet.control.azimuth/index.js',
+ 'src/lib/leaflet.control.layers.minimize/index.js',
+ 'src/lib/stripBom/index.js',
+ 'src/lib/leaflet.control.layers.events/index.js',
+ 'src/lib/leaflet.layer.rasterize/CanvasMarkers.js',
+ 'src/lib/leaflet.layer.rasterize/imgFromDataString.js',
+ 'src/lib/leaflet.layer.rasterize/WestraPasses.js',
+ 'src/lib/leaflet.layer.rasterize/index.js',
+ 'src/lib/leaflet.layer.rasterize/TileLayer.js',
+ 'src/lib/leaflet.layer.rasterize/Google.js',
+ 'src/lib/leaflet.layer.rasterize/MeasuredLine.js',
+ 'src/lib/leaflet.layer.rasterize/Bing.js',
+ 'src/lib/leaflet.layer.rasterize/Yandex.js',
+ 'src/lib/leaflet.layer.bing/dates.js',
+ 'src/lib/leaflet.layer.bing/index.js',
+ 'src/lib/logging/index.js',
+ 'src/lib/iconFromBackgroundImage/index.js',
+ 'src/lib/leaflet.controls.raise-on-focus/index.js',
+ 'src/lib/leaflet.control.elevation-profile/index.js',
+ 'src/lib/leaflet.control.layers.configure/index.js',
+ 'src/lib/leaflet.control.layers.configure/customLayer.js',
+ 'src/lib/leaflet.control.locate/index.js',
+ 'src/lib/leaflet.layer.westraPasses/index.js',
+ 'src/lib/leaflet.layer.westraPasses/westraPassesMarkers.js',
+ 'src/lib/elevations/index.js',
+ 'src/lib/popup-window/index.js',
+ 'src/lib/googleMapsApi/index.js',
+ // 'src/vendored/mapbbcode/FunctionButton.js',
+ // 'src/vendored/github.com/augustl/js-unzip/js-unzip.js',
+ // 'src/vendored/github.com/eligrey/FileSaver.js',
+ // 'src/vendored/github.com/bbecquet/Leaflet.RotatedMarker/leaflet.rotatedMarker.js',
+ 'src/config.js',
+ 'src/index.js',
+ 'src/secrets.js',
+ 'src/App.js',
+ 'src/layers.js',
+];
diff --git a/eslint_rules/prettier.js b/eslint_rules/prettier.js
@@ -0,0 +1,17 @@
+'use strict';
+
+module.exports = {
+ extends: ['prettier'],
+ plugins: ['prettier'],
+ rules: {
+ 'prettier/prettier': 'error',
+ /* rules softly disabled by prettier config*/
+ 'max-len': ['error', {code: 120}],
+ 'arrow-body-style': ['error', 'as-needed'],
+ 'curly': 'error',
+ 'no-confusing-arrow': 'error',
+ 'no-tabs': 'error',
+ 'no-unexpected-multiline': 'error',
+ 'quotes': ['error', 'single', {allowTemplateLiterals: false}],
+ },
+};
diff --git a/eslint_rules/relax_legacy.js b/eslint_rules/relax_legacy.js
@@ -0,0 +1,23 @@
+'use strict';
+
+module.exports = {
+ rules: {
+ 'no-constant-condition': ['error', {checkLoops: false}], // allow `while (true)`
+ 'no-prototype-builtins': 'off',
+ 'no-invalid-this': 'off', // 44 occurencies in old code
+ 'no-magic-numbers': 'off', // 1188 occurencies in old code
+ 'no-param-reassign': 'off', // 91 occurencies in old code
+ 'no-warning-comments': 'off', // 15 occurencies in old code
+ 'no-shadow': 'off', // 83 occurencies in old code
+ 'camelcase': 'off', // 203 occurencies in old code
+ 'comma-dangle': ['error', 'only-multiline'], // 697 issues with always-multiline
+ 'quotes': 'off', // 73 occurencies in old code
+ 'function-paren-newline': 'off', // > 200 occurencies in old code
+ 'indent': 'off', // > 7000 occurencies in old code
+ 'no-multi-assign': 'off', // 31 occurencies in old code
+ 'no-var': 'off', // 330 occurencies in old code
+ 'one-var': 'off', // 122 occurencies in old code
+ 'prefer-const': 'off', // 375 occurencies in old code
+ 'prefer-template': 'off', // 70 occurencies in old code,
+ },
+};
diff --git a/eslint_rules/relax_protobuf.js b/eslint_rules/relax_protobuf.js
@@ -0,0 +1,17 @@
+'use strict';
+
+module.exports = {
+ rules: {
+ 'curly': 'off',
+ 'strict': 'off',
+ 'max-len': 'off',
+ 'no-multiple-empty-lines': 'off',
+ 'space-before-function-paren': 'off',
+ 'quote-props': 'off',
+ 'no-var': 'off',
+ 'no-multi-assign': 'off',
+ 'quotes': 'off',
+ 'comma-dangle': ['error', 'only-multiline'],
+ 'no-shadow': 'off',
+ },
+};
diff --git a/eslint_rules/relax_tests.js b/eslint_rules/relax_tests.js
@@ -0,0 +1,8 @@
+'use strict';
+
+module.exports = {
+ rules: {
+ 'max-nested-callbacks': ['error', 5],
+ 'no-invalid-this': 'off',
+ },
+};
diff --git a/eslint_rules/relax_vendored.js b/eslint_rules/relax_vendored.js
@@ -0,0 +1,51 @@
+'use strict';
+
+module.exports = {
+ rules: {
+ 'semi': 'off',
+ 'no-console': 'off',
+ 'block-scoped-var': 'off',
+ 'consistent-return': 'off',
+ 'curly': 'off',
+ 'no-empty-function': 'off',
+ 'no-implicit-coercion': 'off',
+ 'no-magic-numbers': 'off',
+ 'no-multi-spaces': 'off',
+ 'no-param-reassign': 'off',
+ 'no-throw-literal': 'off',
+ 'no-warning-comments': 'off',
+ 'require-unicode-regexp': 'off',
+ 'strict': 'off',
+ 'no-shadow': 'off',
+ 'no-use-before-define': 'off',
+ 'camelcase': 'off',
+ 'comma-dangle': 'off',
+ 'comma-style': 'off',
+ 'consistent-this': 'off',
+ 'func-style': 'off',
+ 'max-len': 'off',
+ 'no-tabs': 'off',
+ 'quotes': 'off',
+ 'indent': 'off',
+ 'keyword-spacing': 'off',
+ 'linebreak-style': 'off',
+ 'no-multi-assign': 'off',
+ 'no-multiple-empty-lines': 'off',
+ 'no-plusplus': 'off',
+ 'no-var': 'off',
+ 'object-curly-spacing': 'off',
+ 'one-var': 'off',
+ 'operator-linebreak': 'off',
+ 'padded-blocks': 'off',
+ 'semi-spacing': 'off',
+ 'semi-style': 'off',
+ 'space-before-blocks': 'off',
+ 'space-before-function-paren': 'off',
+ 'space-in-parens': 'off',
+ 'space-infix-ops': 'off',
+ 'space-unary-ops': 'off',
+ 'spaced-comment': 'off',
+ 'no-invalid-this': 'off',
+ 'function-paren-newline': 'off',
+ },
+};
diff --git a/myEslintBrowserRules.js b/myEslintBrowserRules.js
@@ -1,7 +0,0 @@
-'use strict';
-module.exports = {
- extends: ['./myEslintRules.js'],
- rules: {
- 'no-console': 'error',
- },
-};
diff --git a/myEslintRules.js b/myEslintRules.js
@@ -1,277 +0,0 @@
-'use strict';
-
-module.exports = {
- extends: ['eslint:recommended'],
- rules: {
- 'accessor-pairs': 'error',
- 'array-bracket-newline': ['error', 'consistent'],
- 'array-bracket-spacing': 'error',
- 'array-callback-return': 'error',
- 'array-element-newline': ['error', 'consistent'],
- 'arrow-body-style': ['error', 'as-needed'], // disabled by prettier-config
- 'arrow-parens': 'error',
- 'arrow-spacing': 'error',
- 'block-scoped-var': 'error',
- // 'block-spacing': 'error', // for single line blocks, not needed
- 'brace-style': 'error',
- // 'callback-return': 'error', // specific to nodejs, skip
- 'camelcase': ['error', {allow: ['_unused_[^_]+']}],
- // 'capitalized-comments': 'error', // checked, declined
- // 'class-methods-use-this': 'error', // checked, declined
- 'comma-dangle': ['error', 'always-multiline'],
- 'comma-spacing': 'error',
- 'comma-style': 'error',
- 'complexity': 'error',
- 'computed-property-spacing': 'error',
- 'consistent-return': 'error',
- 'consistent-this': 'error',
- // 'constructor-super': 'error', // in eslint-recommended
- 'curly': 'error', // disabled by prettier-config
- 'default-case': 'error',
- 'default-param-last': 'error',
- 'dot-location': ['error', 'property'],
- // 'dot-notation': 'error', // checked, declined
- 'eol-last': 'error',
- 'eqeqeq': 'error',
- // 'for-direction': 'error', // in eslint-recommended
- 'func-call-spacing': 'error',
- // 'func-name-matching': 'error', // checked, declined
- // 'func-names': 'error', // checked, declined
- 'func-style': ['error', 'declaration'],
- // 'function-call-argument-newline': 'error', // checked, declined
- 'function-paren-newline': 'error',
- 'generator-star-spacing': ['error', {named: 'after', anonymous: 'neither', method: 'before'}],
- // 'getter-return': 'error', // in eslint-recommended
- // 'global-require': 'error', // specific to nodejs, skip
- 'grouped-accessor-pairs': 'error',
- 'guard-for-in': 'error',
- // 'handle-callback-err': 'error', // specific to nodejs, skip
- // 'id-blacklist': 'error', // checked, declined
- // 'id-length': 'error', // checked, declined
- // 'id-match': 'error', // checked, declined
- // 'implicit-arrow-linebreak': 'error', // checked, declined
- 'indent': 'error',
- // 'init-declarations': 'error', // checked, declined
- // 'jsx-quotes': 'error', // jsx not used
- 'key-spacing': 'error',
- 'keyword-spacing': 'error',
- // 'line-comment-position': 'error', //checked, declined
- 'linebreak-style': 'error',
- // 'lines-around-comment': 'error', // checked, declined
- 'lines-between-class-members': ['error', 'always', {exceptAfterSingleLine: true}],
- // 'max-classes-per-file': 'error', // checked, declined
- 'max-depth': 'error',
- 'max-len': ['error', {code: 120}],
- // 'max-lines': 'error', // checked, declined
- // 'max-lines-per-function': 'error', // checked, declined
- 'max-nested-callbacks': ['error', 2],
- // 'max-params': 'error', // checked, declined
- // 'max-statements': 'error', // checked, declined
- 'max-statements-per-line': 'error',
- // 'multiline-comment-style': 'error', // checked, declined
- // 'multiline-ternary': 'error', // checked, declined
- 'new-cap': 'error',
- 'new-parens': 'error',
- // 'newline-per-chained-call': 'error', // checked, declined
- // 'no-alert': 'error', // checked, declined
- 'no-array-constructor': 'error',
- // 'no-async-promise-executor': 'error', // in eslint-recommended
- // 'no-await-in-loop': 'error', // checked, declined
- // 'no-bitwise': 'error', // checked, declined
- // 'no-buffer-constructor': 'error', // specific to nodejs, skip
- 'no-caller': 'error',
- // 'no-case-declarations': 'error', // in eslint-recommended
- // 'no-class-assign': 'error', // in eslint-recommended
- // 'no-compare-neg-zero': 'error', // in eslint-recommended
- // 'no-cond-assign': 'error', // in eslint-recommended
- 'no-confusing-arrow': 'error',
- // 'no-console': 'error', // checked, declined
- // 'no-const-assign': 'error', // in eslint-recommended
- // 'no-constant-condition': 'error', // in eslint-recommended
- 'no-constructor-return': 'error',
- // 'no-continue': 'error', // checked, declined
- // 'no-control-regex': 'error', // in eslint-recommended
- // 'no-debugger': 'error', // in eslint-recommended
- // 'no-delete-var': 'error', // in eslint-recommended
- // 'no-div-regex': 'error', // checked, declined
- // 'no-dupe-args': 'error', // in eslint-recommended
- // 'no-dupe-class-members': 'error', // in eslint-recommended
- 'no-dupe-else-if': 'error',
- // 'no-dupe-keys': 'error', // in eslint-recommended
- // 'no-duplicate-case': 'error', // in eslint-recommended
- 'no-duplicate-imports': 'error',
- 'no-else-return': 'error',
- // 'no-empty': 'error', // in eslint-recommended
- // 'no-empty-character-class': 'error', // in eslint-recommended
- 'no-empty-function': 'error',
- // 'no-empty-pattern': 'error', // in eslint-recommended
- 'no-eq-null': 'error',
- 'no-eval': 'error',
- // 'no-ex-assign': 'error', // in eslint-recommended
- 'no-extend-native': 'error',
- 'no-extra-bind': 'error',
- // 'no-extra-boolean-cast': 'error', // in eslint-recommended
- 'no-extra-label': 'error',
- // 'no-extra-parens': 'error', // checked, declined
- // 'no-extra-semi': 'error', // in eslint-recommended
- // 'no-fallthrough': 'error', // in eslint-recommended
- 'no-floating-decimal': 'error',
- // 'no-func-assign': 'error', // in eslint-recommended
- // 'no-global-assign': 'error', // in eslint-recommended
- 'no-implicit-coercion': 'error',
- 'no-implicit-globals': 'error',
- 'no-implied-eval': 'error',
- 'no-import-assign': 'error',
- // 'no-inline-comments': 'error', // checked, declined
- // 'no-inner-declarations': 'error', // in eslint-recommended
- // 'no-invalid-regexp': 'error', // in eslint-recommended
- 'no-invalid-this': 'error',
- // 'no-irregular-whitespace': 'error', // in eslint-recommended
- 'no-iterator': 'error',
- 'no-label-var': 'error',
- 'no-labels': 'error', // not quire sure if this should be enabled
- 'no-lone-blocks': 'error',
- // 'no-lonely-if': 'error', // checked, declined
- 'no-loop-func': 'error',
- // 'no-magic-numbers': 'error', // checked, declined
- // 'no-misleading-character-class': 'error', // in eslint-recommended
- // 'no-mixed-operators': 'error', // checked, declined
- 'no-mixed-requires': 'error',
- // 'no-mixed-spaces-and-tabs': 'error', // in eslint-recommended
- 'no-multi-assign': 'error',
- 'no-multi-spaces': [
- 'error',
- {
- ignoreEOLComments: true,
- exceptions: {Property: false},
- },
- ],
- 'no-multi-str': 'error',
- 'no-multiple-empty-lines': ['error', {max: 1}],
- 'no-negated-condition': 'error',
- 'no-nested-ternary': 'error',
- 'no-new': 'error',
- 'no-new-func': 'error',
- 'no-new-object': 'error',
- 'no-new-require': 'error',
- // 'no-new-symbol': 'error', // in eslint-recommended
- 'no-new-wrappers': 'error',
- // 'no-obj-calls': 'error', // in eslint-recommended
- // 'no-octal': 'error', // in eslint-recommended
- 'no-octal-escape': 'error',
- 'no-param-reassign': 'error',
- 'no-path-concat': 'error',
- 'no-plusplus': ['error', {allowForLoopAfterthoughts: true}],
- // 'no-process-env': 'error', // checked, declined
- // 'no-process-exit': 'error', // checked, declined
- 'no-proto': 'error',
- // 'no-prototype-builtins': 'error', // in eslint-recommended
- // 'no-redeclare': 'error', // in eslint-recommended
- // 'no-regex-spaces': 'error', // in eslint-recommended
- // 'no-restricted-globals': 'error', // no forbidden globals defined so far
- // 'no-restricted-imports': 'error', // checked, declined
- // 'no-restricted-modules': 'error', // checked, declined
- // 'no-restricted-properties': 'error', // no forbidden properties defined so far
- 'no-restricted-syntax': ['error', 'SequenceExpression'],
- 'no-return-assign': 'error',
- 'no-return-await': 'error',
- 'no-script-url': 'error',
- // 'no-self-assign': 'error', // in eslint-recommended
- 'no-self-compare': 'error',
- 'no-sequences': 'error',
- 'no-setter-return': 'error',
- 'no-shadow': ['error', {builtinGlobals: true}],
- // 'no-shadow-restricted-names': 'error', // in eslint-recommended
- // 'no-sparse-arrays': 'error', // in eslint-recommended
- // 'no-sync': 'error', // checked, declined
- 'no-tabs': 'error',
- 'no-template-curly-in-string': 'error',
- // 'no-ternary': 'error', // checked, declined
- // 'no-this-before-super': 'error', // in eslint-recommended
- 'no-throw-literal': 'error',
- 'no-trailing-spaces': 'error',
- // 'no-undef': 'error', // in eslint-recommended
- 'no-undef-init': 'error',
- // 'no-undefined': 'error', // not needed since no-global-assign and no-shadow-restricted-names are enabled
- // 'no-underscore-dangle': 'error', // checked, declined
- // 'no-unexpected-multiline': 'error', // in eslint-recommended
- 'no-unmodified-loop-condition': 'error',
- 'no-unneeded-ternary': 'error',
- // 'no-unreachable': 'error', // in eslint-recommended
- // 'no-unsafe-finally': 'error', // in eslint-recommended
- // 'no-unsafe-negation': 'error', // in eslint-recommended
- 'no-unused-expressions': 'error',
- // 'no-unused-labels': 'error', // in eslint-recommended
- 'no-unused-vars': ['error', {argsIgnorePattern: '_unused(_.+)?'}], // redefine eslint-recommended
- 'no-use-before-define': 'error',
- 'no-useless-call': 'error',
- // 'no-useless-catch': 'error', // in eslint-recommended
- 'no-useless-computed-key': ['error', {enforceForClassMembers: true}],
- 'no-useless-concat': 'error',
- 'no-useless-constructor': 'error',
- // 'no-useless-escape': 'error', // in eslint-recommended
- 'no-useless-rename': 'error',
- 'no-useless-return': 'error',
- 'no-var': 'error',
- 'no-void': 'error',
- 'no-warning-comments': 'error',
- 'no-whitespace-before-property': 'error',
- // 'no-with': 'error', // in eslint-recommended
- // 'nonblock-statement-body-position': 'error', // not needed since if-s without block are not allowed
- 'object-curly-newline': 'error',
- 'object-curly-spacing': 'error',
- 'object-property-newline': ['error', {allowAllPropertiesOnSameLine: true}],
- // 'object-shorthand': 'error', // checked, declined
- 'one-var': ['error', 'never'],
- 'one-var-declaration-per-line': 'error',
- 'operator-assignment': 'error',
- 'operator-linebreak': 'error',
- 'padded-blocks': ['error', 'never'],
- // 'padding-line-between-statements': 'error', // checked, declined
- // 'prefer-arrow-callback': 'error', // checked, declined
- 'prefer-const': 'error',
- // 'prefer-destructuring': 'error', // checked, declined
- 'prefer-exponentiation-operator': 'error',
- // 'prefer-named-capture-group': 'error', // checked, declined
- 'prefer-numeric-literals': 'error',
- 'prefer-object-spread': 'error',
- 'prefer-promise-reject-errors': 'error',
- 'prefer-regex-literals': 'error',
- 'prefer-rest-params': 'error',
- 'prefer-spread': 'error',
- // 'prefer-template': 'error', // checked, declined
- 'quote-props': ['error', 'consistent-as-needed'],
- 'quotes': ['error', 'single', {allowTemplateLiterals: false}],
- 'radix': 'error',
- 'require-atomic-updates': 'error',
- // 'require-await': 'error', // checked, declined
- 'require-unicode-regexp': 'error',
- // 'require-yield': 'error', // in eslint-recommended
- 'rest-spread-spacing': 'error',
- 'semi': 'error',
- 'semi-spacing': 'error',
- 'semi-style': 'error',
- // 'sort-imports': 'error', // checked, declined
- // 'sort-keys': 'error', // checked, declined
- // 'sort-vars': 'error', // checked, declined
- 'space-before-blocks': 'error',
- 'space-before-function-paren': ['error', 'never'],
- 'space-in-parens': 'error',
- 'space-infix-ops': 'error',
- 'space-unary-ops': 'error',
- 'spaced-comment': 'error',
- 'strict': ['error', 'global'],
- 'switch-colon-spacing': 'error',
- 'symbol-description': 'error',
- 'template-curly-spacing': 'error',
- 'template-tag-spacing': 'error',
- // 'unicode-bom': 'error', // checked, declined
- // 'use-isnan': 'error', // in eslint-recommended
- // 'valid-typeof': 'error', // in eslint-recommended
- // 'vars-on-top': 'error', // vars should be forbidden
- // 'wrap-iife': 'error', // checked, declined
- // 'wrap-regex': 'error', // checked, declined
- 'yield-star-spacing': 'error',
- 'yoda': 'error',
- },
-};
